[Asterisk-code-review] app queue: Added reason pause of member (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: app_queue: Added reason pause of member
......................................................................


Patch Set 1:

Sounds like you haven't used the Asterisk testsuite as of yet, so I'll start with some basics:

First you'll want to check out the following page:

https://wiki.asterisk.org/wiki/display/AST/Installing+the+Asterisk+Test+Suite

Specifically, the child pages on installing and running the testsuite.

Next I'd suggest thinking about the type of scenario you'll need to test out your changes/additions. Will it need to have external calls dialing into Asterisk? Then you might need a sipp scenario, etc...

After you have an idea of what you need to do I'd suggest searching the testsuite to see if a test is already doing similar. If so then you can simply pattern your test after that one. At the very least looking at other tests you'll see many of the same patterns that you can and should use in your test(s).

For instance you'll want to verify that the raised AMI event has the correct paused reason in it. There are many tests in the testsuite that check the status of an AMI event through the EventActionModule (see tests/channels/pjsip/ami/show_endpoints/test-config.yaml for a simple example of its use). Many recent tests have been written under tests/channels/pjsip/ so that is a good place to look for examples.

You'll of course need to setup something involving queues. Maybe a test beneath tests/apps/queues will get you partly there.

Note that while tests can be written in various languages (you may see lua tests, bash tests, etc...) the preferred language to use is python. However you may be able to specify all you need in the test-config.yaml itself and not need to write any actual test code.

Hope that helps get you started. Post here if you have more questions or add the test as a review in gerrit and discussion can take place there.

-- 
To view, visit https://gerrit.asterisk.org/1448
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5db503482f50764c15e2020196c785f59d4a68e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: No