[Asterisk-code-review] chan sip.c: Start ICE negotiation when response is sent or r... (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: chan_sip.c: Start ICE negotiation when response is sent or received.
......................................................................


Patch Set 3:

{quote}
Eugene Voityuk
Guys who is responsible to push it to production? For me it's very hard to use this review system, i am totally new to everything here.
{quote}

{quote}
Joshua Colp
Once all reviews are done and accepted the changes will be merged in.
{quote}

The review is exactly what gets merged into the branch when the patch is
accepted.  This is why things need to be right before acceptance because
git doesn't allow alterations to the commit once merged.  It is also why
there has to be a review for every branch the patch is to be incorporated.

-- 
To view, visit https://gerrit.asterisk.org/1751
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a632bde9e9827871b09141d82747e08379a8ca
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No