[Asterisk-code-review] chan sip.c: Start ICE negotiation when response is sent or r... (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip.c: Start ICE negotiation when response is sent or received.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

This will need to be cherry picked into 13/master as well.

https://gerrit.asterisk.org/#/c/1751/2/channels/chan_sip.c
File channels/chan_sip.c:

Line 13277: 				add_ice_to_sdp(p->rtp, &a_audio);
          : 				/* Start ICE negotiation, and setting that we are controlled agent,
          : 				   as this is response to offer */
          : 				if (resp->method == SIP_RESPONSE) {
          : 					start_ice(p->rtp, 0);
          : 				}
> Shouldn't ice be started before adding ice candidates to the sdp?
Shouldn't matter.


-- 
To view, visit https://gerrit.asterisk.org/1751
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a632bde9e9827871b09141d82747e08379a8ca
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes