[Asterisk-code-review] res pjsip/config transport: Prevent async operations > 1 whe... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip/config_transport: Prevent async_operations > 1 when protocol = tls
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1785/1//COMMIT_MSG
Commit Message:

Line 15: ASTERISK-25615 #comment Work-around until fixed upstream
> Please don't use anything other than #close or nothing.
Update the wiki please. :)


https://gerrit.asterisk.org/#/c/1785/1/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

Line 222: 		if ( transport->async_operations > 1) {
> guidelines: spacing
Oops, didn't see the space.

People who set async_operations generally have a reason for doing so.  Silently ignoring their request can only lead to confusion if they're expecting multiple async operations and aren't getting them.


-- 
To view, visit https://gerrit.asterisk.org/1785
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76b9a5b2a5a0054fe71ca5851e635f2dca7685a6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes