[Asterisk-code-review] chan sip: Check sip pvt pointer in ast channel get t38 state(c) (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Dec 8 05:51:52 CST 2015


Joshua Colp has posted comments on this change.

Change subject: chan_sip: Check sip_pvt pointer in ast_channel_get_t38_state(c)
......................................................................


Patch Set 1: Code-Review-1

How would you get into this state? If the channel is being hung up (ast_hangup has been called/is being called) then all references are gone, so whatever is accessing the channel is doing so illegally and the channel structure itself may become invalid soon anyway.

-- 
To view, visit https://gerrit.asterisk.org/1776
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaa707c04b865a290ffab719bd2e5c48ff667c7b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Filip Jenicek <phill at janevim.cz>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list