[Asterisk-code-review] chan sip: Support parsing of Q.850 reason header in SIP BYE ... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip: Support parsing of Q.850 reason header in SIP BYE and CANCEL requests.
......................................................................


Patch Set 2: Code-Review+1

I've gone ahead and squashed things together so the review is correct. In the future you can do this yourself pretty easily by doing:

git review -d <review number of review with findings>
Make the changes required
git commit -a --amend
git review <branch>

This will squash your fixes into the commit and update the existing review. If you maintain a branch you can also do the same thing, just minus the git review -d usage (it downloads the review and creates a branch).

Cheers.

-- 
To view, visit https://gerrit.asterisk.org/1750
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be7b34c23a76d0e98dfd0816c89931000ac790
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Christof Lauber <christof.lauber at annax.ch>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No