[Asterisk-code-review] chan sip.c: Start ICE negotiation when response is sent or r... (asterisk[11])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: chan_sip.c: Start ICE negotiation when response is sent or received.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1751/1/channels/chan_sip.c
File channels/chan_sip.c:

Line 13274: 				start_ice(p->rtp, 0);
This function is also called when adding SDP to an outgoing INVITE, won't that cause ICE to start prematurely and cause spurious logging/actions until the response occurs where it is started again?


-- 
To view, visit https://gerrit.asterisk.org/1751
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a632bde9e9827871b09141d82747e08379a8ca
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Eugene Voityuk <eugene at thirdlane.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes