[Asterisk-code-review] channels/chan sip: 180 Ringing not sent after 183 Session Pr... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: channels/chan_sip: 180 Ringing not sent after 183 Session Progress
......................................................................


Patch Set 1:

> If a device melts down for a 180 after 183 then it's their problem
 > not ours. 183 is just a media state but the 180 is a call state
 > that is in fact important for a lot of devices that signals (tells
 > the user)  ringing in various ways. Suppressing that state change
 > is generally bad.
 > 
 > A side note: This issue is in the issue tracker. Why do we have
 > discussions in two different systems. Confusing to me.

Sorry about that - I missed your question here Olle.

When an issue is filed, discussion can occur there if there is no patch. Once a patch is proposed on Gerrit, discussion about that code change would logically occur there.

That's really no different than Github. If you have an issue, you discuss it there; once there's a PR, the discussion of the code change happens on the PR.

-- 
To view, visit https://gerrit.asterisk.org/1696
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I498fed853128831b80536f8818cd7b60e641f39c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Morten Tryfoss <morten at tryfoss.no>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Morten Tryfoss <morten at tryfoss.no>
Gerrit-Reviewer: Olle Johansson <oej at edvina.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No