[Asterisk-code-review] res pjsip/contacts/statsd: Make contact lifecycle events mo... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_pjsip/contacts/statsd:  Make contact lifecycle events more consistent
......................................................................


Patch Set 2:

> This looks to be a much cleaner implementation of what I was going
 > for. Nice work!
 > 
 > Tested this locally as well, using ARI to create/delete AoRs, and
 > the behaviour looked correct both before and after the patch. Since
 > this fixes the bug where 'Removed' states would never be
 > transmitted, the test will fail after this patch - I'll update that
 > shortly.
 > 
 > Thanks again!

Disregard, just saw that you already took care of the test too. Awesome!

-- 
To view, visit https://gerrit.asterisk.org/1768
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b56e7dfc3be3baaaf6f1eac5b2068a0b79e357d
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No