[Asterisk-code-review] chan sip: option 'notifyringing' doc fix and addition of 'no... (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Fri Dec 4 12:14:47 CST 2015


Kevin Harwell has posted comments on this change.

Change subject: chan_sip: option 'notifyringing' doc fix and addition of 'notifyringingprio'
......................................................................


Patch Set 2:

> How about this: instead of a new option, I make notifyringing a three-state key? false, true, notinuse?

This sounds reasonable to me.

-- 
To view, visit https://gerrit.asterisk.org/1649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88f7036ee084bb3f43b74f15612695c6708f74aa
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Ward van Wanrooij <ward at ward.nu>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Ward van Wanrooij <ward at ward.nu>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list