[Asterisk-code-review] res format attr opus: Update to latest RFC 7587. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_format_attr_opus: Update to latest RFC 7587.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/1674/3/res/res_format_attr_opus.c
File res/res_format_attr_opus.c:

Line 124: 	if (attributes == strstr(attributes, "stereo=1")) {
> Yes, strncmp avoids an unnecessary scan and makes this code even more reada
I agree the code will be more readable, so no comment necessary.


-- 
To view, visit https://gerrit.asterisk.org/1674
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae85ba3e5960bfd5d51cf65bcffad00dd4875a73
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes