[Asterisk-code-review] res pjsip: Use a MD5 hash for static Contact IDs (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip: Use a MD5 hash for static Contact IDs
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/1756/1/res/res_pjsip/location.c
File res/res_pjsip/location.c:

Line 397: 		char contact_id[strlen(aor_id) + sizeof(hash) + 2 + 1];
nit: sizeof(hash) includes the hash's null terminator so the +2 for the two string's null terminators is one too many now.


-- 
To view, visit https://gerrit.asterisk.org/1756
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic674a3307280365b4a45864a3571c295b48a01e2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes