[Asterisk-code-review] res format attr vp8: In SDP, forward max-fr and max-fs for v... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_format_attr_vp8: In SDP, forward max-fr and max-fs for video-codec VP8.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1676/2/res/res_format_attr_vp8.c
File res/res_format_attr_vp8.c:

Line 68: 	if (original) {
       : 		*attr = *original;
       : 	}
Since the default attributes are not zero shouldn't there be an else clause and the ast_calloc above becomes just ast_malloc:

if () {
} else {
  *addr = default_vp8_attr;
}


-- 
To view, visit https://gerrit.asterisk.org/1676
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae00071b4ff1ae76f24995aeac4d00284fd14f91
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes