[Asterisk-code-review] res pjsip: Update logging to show contact->uri in messages (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Update logging to show contact->uri in messages
......................................................................


Patch Set 6:

(5 comments)

https://gerrit.asterisk.org/#/c/1731/6/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 79: 		snprintf(rtt, 31, "%" PRId64, status->rtt);
Since you are touching this line, the magic 31 should be replaced by sizeof(rtt).
snprintf will write at most size bytes including the null terminator.


https://gerrit.asterisk.org/#/c/1731/6/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 176: 		return;
Missing unref of status.


Line 182: 		return;
Missing unref of update.


Line 242: 		return;
Missing unref of status.


Line 248: 		return;
Missing unref of update.


-- 
To view, visit https://gerrit.asterisk.org/1731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbec1d2ddbe8461367dd8b6da8a6f47f6fe511
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes