[Asterisk-code-review] app queue: Show reason of pause on CLI (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_queue: Show reason of pause on CLI
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Minor nits should fix

https://gerrit.asterisk.org/#/c/1666/1/apps/app_queue.c
File apps/app_queue.c:

Line 9258: 						ast_str_append(&out, 0, "%s%s%s",
         : 							ast_term_color(COLOR_BROWN, COLOR_BLACK), " (paused)", ast_term_reset());
There's no reason to have "(paused)" as a passed in parameter when it is a constant string and always going to be added.

"%s(paused)%s"


Line 9261: 						ast_str_append(&out, 0, "%s%s:%s%s%s", 	ast_term_color(COLOR_BROWN, COLOR_BLACK),
         : 							" (paused", mem->reason_paused, ")" , ast_term_reset());
There's no reason to have "(paused" and ")" as passed in parameters when they are constant strings and always going to be added.

"%s(paused:%s)%s"

Also you have an extra tab before the ast_term_color(COLOR_BROWN,... parameter.


-- 
To view, visit https://gerrit.asterisk.org/1666
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I887028a40cd97b350da9a3bb2719616b7fec9864
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: Yes