[Asterisk-code-review] res pjsip: Update logging to show contact->uri in messages (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Update logging to show contact->uri in messages
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1732/2/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 147: 	contact_status->status = CREATED;
You are altering a sorcery controlled immutable object here.  This is generally not a good thing.

In this case I think some statsD events won't get created because of it.


Line 174: 	contact_status->status = REMOVED;
You are altering a sorcery controlled immutable object here.  This is generally not a good thing.

In this case I think some statsD events won't get created because of it.


-- 
To view, visit https://gerrit.asterisk.org/1732
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbec1d2ddbe8461367dd8b6da8a6f47f6fe511
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes