[Asterisk-code-review] res pjsip: Update logging to show contact->uri in messages (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Update logging to show contact->uri in messages
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/1731/3/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 171: 		contact_status->uri = ast_strdup(contact->uri);
Only contact_status->uri what happened to contact_status->aor?

Also need to check for allocation failure.


https://gerrit.asterisk.org/#/c/1731/3/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 99: 	status->aor = ast_strdup(aor);
       : 	if (!status->aor) {
To not have null in either struct ast_sip_contact_status.aor and uri you have to ast_strdup("") into the one you are not filling with a given string.  Otherwise you need a NULL check that you don't need with a stringfield.


Line 132: 	status->uri = ast_strdup(contact->uri);
Need to status->aor = ast_strdup("") here also


Line 180: 	update->uri = ast_strdup(contact->uri);
Need to update->aor = ast_strdup("") here also


Line 246: 	update->uri = ast_strdup(contact->uri);
Need to update->aor = ast_strdup("") here also


-- 
To view, visit https://gerrit.asterisk.org/1731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbec1d2ddbe8461367dd8b6da8a6f47f6fe511
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes