[Asterisk-code-review] Unset BRIDGEPEER when leaving a bridge (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Unset BRIDGEPEER when leaving a bridge
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1749/1/include/asterisk/bridge.h
File include/asterisk/bridge.h:

Line 757: void ast_bridge_vars_set(struct ast_channel *chan, const char *name, const char *pvtid);
Add:
\pre chan must be locked before calling.


Line 766: void ast_bridge_vars_clear(struct ast_channel *chan);
This does not need to exist as it can be written in terms of ast_bridge_vars_set().

ast_bridge_vars_set(chan, NULL, NULL);


https://gerrit.asterisk.org/#/c/1749/1/main/bridge_channel.c
File main/bridge_channel.c:

Line 292: 	ast_bridge_vars_clear(bridge_channel->chan);
ast_channel_lock(bridge_channel->chan);
ast_bridge_vars_set(bridge_channel->chan, NULL, NULL);
ast_channel_unloc(bridge_channel->chan);


-- 
To view, visit https://gerrit.asterisk.org/1749
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I753ead2fffbfc65427ed4e9244c7066610e546da
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes