[Asterisk-code-review] res pjsip: Update logging to show contact->uri in messages (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Update logging to show contact->uri in messages
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/1731/2/res/res_pjsip/location.c
File res/res_pjsip/location.c:

Line 122: 	contact->aor = ast_strdup(aor);
Should do:
ast_free(contact->aor);
contact->aor = ast_strdup(aor);

Check for allocation failure and cleanup to return NULL.


https://gerrit.asterisk.org/#/c/1731/2/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 173: 	contact_status->uri = ast_strdup(contact->uri);
        : 	contact_status->aor = ast_strdup(contact->aor);
same here about freeing before ast_strdup().

Check for allocation failure and cleanup.


https://gerrit.asterisk.org/#/c/1731/2/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 99: 	status->aor = ast_strdup(aor);
Check for allocation failure and cleanup.


Line 127: 	status->uri = ast_strdup(contact->uri);
Check for allocation failure and cleanup.


Line 170: 	update->uri = ast_strdup(contact->uri);
Check for allocation failure and cleanup.


Line 231: 	update->uri = ast_strdup(contact->uri);
Check for allocation failure and cleanup.


-- 
To view, visit https://gerrit.asterisk.org/1731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbec1d2ddbe8461367dd8b6da8a6f47f6fe511
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes