[Asterisk-code-review] res pjsip: Update logging to show contact->uri in messages (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip:  Update logging to show contact->uri in messages
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1731/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 163: 		AST_STRING_FIELD(aor);
Adding this field breaks ABI compatibility because it shifts everything after it.  Unfortunately, since this is a string field it cannot be put anywhere else in the struct.

This is OK to do in master but not in v13.


Line 198: 	AST_DECLARE_STRING_FIELDS(
        : 		/*! The original contact's URI */
        : 		AST_STRING_FIELD(uri);
        : 		/*! The name of the aor this contact_status belongs to */
        : 		AST_STRING_FIELD(aor);
        : 	);
Same here about ABI compatibility.


-- 
To view, visit https://gerrit.asterisk.org/1731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbec1d2ddbe8461367dd8b6da8a6f47f6fe511
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes