[Asterisk-code-review] res pjsip: Use a SHA1 hash for the statsd label for contacts (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: Use a SHA1 hash for the statsd label for contacts
......................................................................


Patch Set 1: -Code-Review

What I actually would up doing was adding aor to the contact and aor and uri to contact status.  The contact gets aor added in its allocator by parsing the front of the id and contact_status gets filled in pjsip_options.  I'm just testing now to make sure the events and testsuite are ok.  For the static contacts, I'd say make the id the same aor/hash as the dynamic ones. 

For statsd, I'm not sure taking up space in the CLI by outputting the first 10 of the hash is actually going to help.  I wouldn't expect a human to be looking up individual hashes.

-- 
To view, visit https://gerrit.asterisk.org/1727
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf2d4e5b5987bda5823a0d984d15f022d5a835c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No