[Asterisk-code-review] res pjsip: Use a SHA1 hash for the statsd label for contacts (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_pjsip: Use a SHA1 hash for the statsd label for contacts
......................................................................


Patch Set 1:

> Josh took a different approach for the dynamic contacts.  He
 > actually changed the id. I.E.  "<aor>;@<hash>" instead of
 > "<aor>;@<uri>"  I'm  fixing the event and log code to account for
 > that right now.
 > 
 > We should do them both the same way and fix the statsd_log's to
 > send "<aor>/<uri>" instead of the id.  As part of my patch, I've
 > added the aor name to contact to make it easier to deal with.

<aor>/<hash> would be preferable (can't use the URI, as it will still contain reserved characters).

I'm not sure how to snag the AoR ID at that level however. When a contact_status is created, you usually just have the ast_sip_contact object, which doesn't currently cache the AoR. (Sure, it could, but that felt like a rather intrusive change.) Since a contact_status is created relatively often, I don't want to try and do a reverse lookup from the contact object.

Did you have a thought on what to do other than storing the AoR ID on the ast_sip_contact/ast_sip_contact_status objects?

-- 
To view, visit https://gerrit.asterisk.org/1727
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf2d4e5b5987bda5823a0d984d15f022d5a835c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No