[Asterisk-code-review] fix deadlock in ChanSpy, ASTERISK-25321. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: fix deadlock in ChanSpy, ASTERISK-25321.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1165/1//COMMIT_MSG
Commit Message:

Line 7: fix deadlock in ChanSpy, ASTERISK-25321.
Please use commit message template described by the asterisk wiki.  You can see examples of such on other reviews that have been merged.


https://gerrit.asterisk.org/#/c/1165/1/apps/app_chanspy.c
File apps/app_chanspy.c:

Line 635: 	spyee_autochan_chan = spyee_autochan->chan;
        : 	ast_channel_lock(spyee_autochan_chan);
        : 	name = ast_strdupa(ast_channel_name(spyee_autochan->chan));
        : 	ast_channel_unlock(spyee_autochan_chan);
I don't think this is a good fix since the channel pointer in spyee_autochan->chan seems to be changing between locking and unlocking the channel, you need to at least get a ref to the channel.  However, why the channel is changing needs to be determined to have a proper fix since spyee_autochan->chan is used elsewhere in this function.


-- 
To view, visit https://gerrit.asterisk.org/1165
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia516fa2387164ee391bfea8c7a3d18951cfe539c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Filip Frank <Frenkfil at email.cz>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes