[Asterisk-code-review] fix deadlock in ChanSpy, ASTERISK-25321. (asterisk[master])

Filip Frank asteriskteam at digium.com
Mon Aug 31 10:19:40 CDT 2015


Filip Frank has uploaded a new change for review.

  https://gerrit.asterisk.org/1165

Change subject: fix deadlock in ChanSpy, ASTERISK-25321.
......................................................................

fix deadlock in ChanSpy, ASTERISK-25321.

Change-Id: Ia516fa2387164ee391bfea8c7a3d18951cfe539c
---
M apps/app_chanspy.c
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/65/1165/1

diff --git a/apps/app_chanspy.c b/apps/app_chanspy.c
index 3c7a917..a32ba31 100644
--- a/apps/app_chanspy.c
+++ b/apps/app_chanspy.c
@@ -632,9 +632,10 @@
 	spyer_name = ast_strdupa(ast_channel_name(chan));
 	ast_channel_unlock(chan);
 
-	ast_channel_lock(spyee_autochan->chan);
+	spyee_autochan_chan = spyee_autochan->chan;
+	ast_channel_lock(spyee_autochan_chan);
 	name = ast_strdupa(ast_channel_name(spyee_autochan->chan));
-	ast_channel_unlock(spyee_autochan->chan);
+	ast_channel_unlock(spyee_autochan_chan);
 
 	ast_verb(2, "Spying on channel %s\n", name);
 	publish_chanspy_message(chan, spyee_autochan->chan, 1);

-- 
To view, visit https://gerrit.asterisk.org/1165
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia516fa2387164ee391bfea8c7a3d18951cfe539c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Filip Frank <Frenkfil at email.cz>



More information about the asterisk-code-review mailing list