[Asterisk-code-review] res pjsip session: Don't invoke session supplements twice fo... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip_session: Don't invoke session supplements twice for BYE requests.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1153/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 2430: 		if ((e->body.tsx_state.src.rdata->msg_info.msg->type != PJSIP_REQUEST_MSG) ||
         : 			(tsx->method.id != PJSIP_BYE_METHOD)) {
> Why are you blocking requests methods from being handled here?
He's only blocking request messages that are BYE messages. Presumably, if the request is an INVITE then the second case would evaluate to true thus falling into the if clause.


-- 
To view, visit https://gerrit.asterisk.org/1153
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69c17df55ccbb61ef779ac38cc8c6b411376c19a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes