[Asterisk-code-review] lib/python/asterisk/ari: Call parent object initializor for ... (testsuite[master])

Joshua Colp asteriskteam at digium.com
Fri Aug 28 06:43:50 CDT 2015


Joshua Colp has submitted this change and it was merged.

Change subject: lib/python/asterisk/ari: Call parent object initializor for Autobahn 0.10.5-2
......................................................................


lib/python/asterisk/ari: Call parent object initializor for Autobahn 0.10.5-2

In Autobahn release 0.10.5-2, a parent object of the WebSocket client protocol
added an 'is_closed' member variable. If the initializor of the parent class
is never called, the attribute is not created an an exception will be thrown
when the WebSocket disconnects. This patch corrects that issue by properly
calling the parent objects' initializors on creation of our ARI client
protocol.

Change-Id: Ie228090f61dacfcc482188ae8ba82c26f76e2dda
---
M lib/python/asterisk/ari.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Ashley Sanders: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/lib/python/asterisk/ari.py b/lib/python/asterisk/ari.py
index 49faa03..a04696b 100644
--- a/lib/python/asterisk/ari.py
+++ b/lib/python/asterisk/ari.py
@@ -361,6 +361,7 @@
 
         :param receiver The event receiver
         """
+        super(AriClientProtocol, self).__init__()
         LOGGER.debug("Made me a client protocol!")
         self.receiver = receiver
         self.factory = factory

-- 
To view, visit https://gerrit.asterisk.org/1151
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie228090f61dacfcc482188ae8ba82c26f76e2dda
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list