[Asterisk-code-review] CHAOS: do not try to parse a null contact uri (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: CHAOS: do not try to parse a null contact uri
......................................................................


Patch Set 1: Code-Review-1

I'm seconding the -1 here. Have a look at https://issues.asterisk.org/jira/browse/ASTERISK-25295

There is currently a crash occurring sometimes in res_pjsip_path because of a NULL contact URI. On the surface, it seems like the fix you're implementing would fix that problem. However, the real issue here is that we created a contact header with a NULL URI in the first place.

If you want to see my analysis on that issue, have a look at https://issues.asterisk.org/jira/browse/ASTERISK-25295?focusedCommentId=227290&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-227290

The proper fix is to catch parsing errors of URIs earlier so that we never try to send a malformed SIP response through the path module in the first place.

-- 
To view, visit https://gerrit.asterisk.org/1118
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b58aa953889f53a066acfa8ec42bbe544c6c3f6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No