[Asterisk-code-review] res http websocket.c: Add missing unref on an off nominal path. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Wed Aug 19 16:56:35 CDT 2015


Mark Michelson has submitted this change and it was merged.

Change subject: res_http_websocket.c: Add missing unref on an off nominal path.
......................................................................


res_http_websocket.c: Add missing unref on an off nominal path.

Change-Id: I228df6adecd4cb450d03e09e9a38c86bb566e811
---
M res/res_http_websocket.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Mark Michelson: Looks good to me, approved
  Scott Griepentrog: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Matt Jordan: Looks good to me, but someone else must approve



diff --git a/res/res_http_websocket.c b/res/res_http_websocket.c
index 86ec00c..c40aae6 100644
--- a/res/res_http_websocket.c
+++ b/res/res_http_websocket.c
@@ -832,6 +832,7 @@
 			ast_log(LOG_WARNING, "WebSocket connection from '%s' could not be accepted - failed to generate a session id\n",
 				ast_sockaddr_stringify(&ser->remote_address));
 			ast_http_error(ser, 500, "Internal Server Error", "Allocation failed");
+			ao2_ref(protocol_handler, -1);
 			return 0;
 		}
 

-- 
To view, visit https://gerrit.asterisk.org/1113
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I228df6adecd4cb450d03e09e9a38c86bb566e811
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>



More information about the asterisk-code-review mailing list