[Asterisk-code-review] app queue.c: Fix error checking in QUEUE MEMBER() read. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_queue.c: Fix error checking in QUEUE_MEMBER() read.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/1106/2/apps/app_queue.c
File apps/app_queue.c:

Line 8097: 
         : 
         : 
> Why was this log message changed from the original? (Maybe it's superfluous
I changed this message because listing all the valid values was a bit rediculous and the message was so long that it could not fit on one line.


Line 8015: if (ast_strlen_zero(interface)) {
         : 		ast_log(LOG_ERROR, "QUEUE_MEMBER: Missing required interface argument.\n");
         : 		return NULL;
         : 	}
         : 
         : 	m = interface_exists(q, interface);
         : 	if (!m) {
         : 		ast_log(LOG_ERROR, "Queue member interface '%s' not in queue '%s'.\n",
         : 			interface, q->name);
         : 	}
> I think we should be consistent as much as possible when outputting log mes
Consistency is good.  It wasn't the goal of the patch because I wasn't thinging of changing all of the associated messages to a consistent format.  I did reword a few messages because they were a bit awkward.  However, there is more consistency than there was before these patches and I am reluctant to make the indicated change to this patch because the other versions have already been merged.  A follow up patch could be done instead but there are limits to how far something like this should be taken. :)


-- 
To view, visit https://gerrit.asterisk.org/1106
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7294e13d27875851c2f4ef6818adba507509d224
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes