[Asterisk-code-review] app queue.c: Fix error checking in QUEUE MEMBER() read. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_queue.c: Fix error checking in QUEUE_MEMBER() read.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1106/2/apps/app_queue.c
File apps/app_queue.c:

Line 8079: 
> Is there any concern about the change in functionality here?  The previous 
This had caused me some concern in that it might have been a desired feature due to potential legacy behavior of QUEUE_MEMBER.  I could see it if the original function just returned the count when given QUEUE_MEMBER(queue) but that syntax is not allowed.  The earlier (args.argc < 2) check requires a comma so you have to give the awkward syntax QUEUE_MEMBER(queue,).  As a result I felt that the exception was not needed because users would have had to change their dialplans to simply add a comma earlier anyway.


-- 
To view, visit https://gerrit.asterisk.org/1106
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7294e13d27875851c2f4ef6818adba507509d224
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes