[Asterisk-code-review] CHAOS: do not try to parse a null contact uri (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: CHAOS: do not try to parse a null contact uri
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1118/1/res/res_pjsip_path.c
File res/res_pjsip_path.c:

Line 189: 	contact_hdr = pjsip_msg_find_hdr(tdata->msg, PJSIP_H_CONTACT, NULL);
        : 	if (!contact_hdr || !contact_hdr->uri) {
        : 		return;
        : 	}
I suspect this pattern exists in a lot of places.

The question is: should the contact header in PJSIP have ever been created if the URI was returned as NULL? My guess is it shouldn't have been, in which case we're fixing a problem in PJSIP in our code.


-- 
To view, visit https://gerrit.asterisk.org/1118
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b58aa953889f53a066acfa8ec42bbe544c6c3f6
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes