[Asterisk-code-review] app queue.c: Fix setting QUEUE MEMBER 'paused' and 'ringinuse'. (asterisk[11])

[Richard Mudgett]

Hello Mark Michelson, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1102

to look at the new patch set (#2).

Change subject: app_queue.c: Fix setting QUEUE_MEMBER 'paused' and 'ringinuse'.
......................................................................

app_queue.c: Fix setting QUEUE_MEMBER 'paused' and 'ringinuse'.

Setting the 'paused' and 'ringinuse' options on a queue member using the
dialplan function QUEUE_MEMBER did not behave the same way as the
equivalent dialplan applications or AMI actions.

* Made queue_function_mem_write() call the set_member_paused() and
set_member_value() for the 'paused' and 'ringinuse' options respectively.
A beneficial side effect is that the queue name is now optional and sets
the value in all queues the interface is a member.

NOTE: This may fix a consistency issue with the realtime paused setting
since how the value is set is controlled by set_member_paused() which
treats realtime a little better.

* Update QUEUE_MEMBER XML documentation.

* Fix error checking in QUEUE_MEMBER() write.

ASTERISK-25215 #close
Reported by: Lorne Gaetz

Change-Id: I3a016be8dc94d63a9cc155295ff9c9afa5f707cb
---
M apps/app_queue.c
1 file changed, 41 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/1102/2
-- 
To view, visit https://gerrit.asterisk.org/1102
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a016be8dc94d63a9cc155295ff9c9afa5f707cb
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>