[Asterisk-code-review] SIP: Rewrite tcpauthlimit test in Python (testsuite[master])

Ashley Sanders asteriskteam at digium.com
Thu Aug 13 02:43:14 CDT 2015


Hello Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1055

to look at the new patch set (#3).

Change subject: SIP: Rewrite tcpauthlimit test in Python
......................................................................

SIP: Rewrite tcpauthlimit test in Python

What was formerly a Lua test has been ported to a Python such that the
test can now be executed from the Jenkins build agents. Functionally,
the test is identical to its predecessor.

The test is composed of two types of scenarios: SIP Client and SIPp.

The SIP Client scenarios attempt to create n+1 TCP socket connections to
Asterisk, where n is the value of the tcpauthlimit property in sip.conf.
If the tcpauthlimit property is honored, the (n+1)th socket connection
will fail.

The SIPp scenarios attempt to create n*2 SIPp processes, where n is the
value of the tcpauthlimit property in sip.conf. Each SIPp scenario is
configured to connect to the same Asterisk host. If the tcpauthlimit
property is honored, only n of these scenarios will pass, while the
remaining n will fail.

ASTERISK-25225
Reported by Matt Jordan

Change-Id: Ica28ba0ca7ae92b3546da4cd23458f289c111d36
---
M lib/python/asterisk/sipp.py
D tests/channels/SIP/tcpauthlimit/run-test
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/configs/ast1/extensions.conf
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/configs/ast1/sip.conf
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_bob.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_dave.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_jerry.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_jon.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_jorge.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_kevin.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_mark.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_phil.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_stuart.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/inject_minion_tim.csv
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp/uac.xml
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/sipp_scenario.py
A tests/channels/SIP/tcpauthlimit/sipp_client_scenario/test-config.yaml
A tests/channels/SIP/tcpauthlimit/tcp_client_scenario/configs/ast1/extensions.conf
A tests/channels/SIP/tcpauthlimit/tcp_client_scenario/configs/ast1/sip.conf
A tests/channels/SIP/tcpauthlimit/tcp_client_scenario/tcp_scenario.py
A tests/channels/SIP/tcpauthlimit/tcp_client_scenario/test-config.yaml
A tests/channels/SIP/tcpauthlimit/tcpauthlimit.py
D tests/channels/SIP/tcpauthlimit/test-config.yaml
D tests/channels/SIP/tcpauthlimit/test.lua
A tests/channels/SIP/tcpauthlimit/tests.yaml
M tests/channels/SIP/tests.yaml
26 files changed, 1,441 insertions(+), 138 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/55/1055/3
-- 
To view, visit https://gerrit.asterisk.org/1055
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica28ba0ca7ae92b3546da4cd23458f289c111d36
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list