[Asterisk-code-review] ARI: Retrieve existing log channels (asterisk[13])

Joshua Colp asteriskteam at digium.com
Fri Aug 7 14:32:13 CDT 2015


Joshua Colp has posted comments on this change.

Change subject: ARI: Retrieve existing log channels
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/986/10/main/logger.c
File main/logger.c:

Line 1046: 			return AST_LOGGER_FAILURE;
You have an off-nominal here that doesn't release the lock.


-- 
To view, visit https://gerrit.asterisk.org/986
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb08b93e3b938c991f3f56cc5d188654768a808
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Emidy <jemidy at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Emidy <jemidy at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list