[Asterisk-code-review] ARI: Creating log channels (asterisk[13])

Ashley Sanders asteriskteam at digium.com
Thu Aug 6 15:58:36 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: ARI: Creating log channels
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1042/2/main/logger.c
File main/logger.c:

Line 1077: 			success = 1;
You can break out of here instead of continuing the loop. If you need to traverse the list again, then use a new AST_RWLIST_TRAVERSE call later.


-- 
To view, visit https://gerrit.asterisk.org/1042
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a20e5c75716dfbb6b62fd3474faf55be20bd782
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Emidy <jemidy at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list