[Asterisk-code-review] res pjsip: Ensure sanitized XML is NULL terminated. (asterisk[master])

Mark Michelson asteriskteam at digium.com
Wed Aug 5 13:36:23 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: res_pjsip: Ensure sanitized XML is NULL terminated.
......................................................................


Patch Set 1:

I would suggest adding a second unit test case where an unsanitized string is small enough to fit in the output buffer, but the sanitized string is too large. Ensure that the buffer is not being overrun.

-- 
To view, visit https://gerrit.asterisk.org/1040
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743dd9809d3e13d722df1b0509dfe34621398302
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list