[Asterisk-code-review] main/pbx: Improve performance of dialplan reloads with a lar... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Thu Apr 30 17:19:52 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: main/pbx: Improve performance of dialplan reloads with a large number of hints
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/312/5/main/pbx.c
File main/pbx.c:

Line 1166: 		if (!device) {
         : 			continue;
         : 		}
can device ever be NULL now?
If so then we now have an infinite loop.


-- 
To view, visit https://gerrit.asterisk.org/312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list