[Asterisk-code-review] main/pbx: Improve performance of dialplan reloads with large... (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: main/pbx: Improve performance of dialplan reloads with large numbers of hints
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/312/4/main/pbx.c
File main/pbx.c:

Line 1164: 	for (; i < AST_VECTOR_SIZE(&hint->devices); i++) {
         : 		struct hintdevice_remove_data remove_data;
         : 		char *device = AST_VECTOR_GET(&hint->devices, i);
         : 
         : 		if (!device) {
         : 			continue;
         : 		}
         : 
         : 		remove_data.device = device;
         : 		remove_data.hint = hint;
         : 
         : 		ao2_t_callback(hintdevices, OBJ_SEARCH_KEY | OBJ_UNLINK | OBJ_NODATA,
         : 			hintdevice_remove_cb, &remove_data, "Remove device from container");
         : 		AST_VECTOR_REMOVE_UNORDERED(&hint->devices, i);
         : 		ast_free(device);
         : 	}
> I just saw this for loop and it seems odd to me. i increases with each iter
Yup, it's wrong. Thanks for catching the issue in my while loop implementation in #asterisk-dev.

/me blames a long day


-- 
To view, visit https://gerrit.asterisk.org/312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes