[Asterisk-code-review] main/pbx: Improve performance of dialplan reloads with a lar... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: main/pbx: Improve performance of dialplan reloads with a large number of hints
......................................................................


Patch Set 2:

(2 comments)

Uh for some reason I can't put + or - scores on this review, but assume since I still have findings that it's a -1 right now.

https://gerrit.asterisk.org/#/c/312/2/main/pbx.c
File main/pbx.c:

Line 1155: 		return CMP_MATCH | CMP_STOP;
Heh, after all the talk about CMP_STOP, it turns out that you don't need it here since you're no longer using OBJ_MULTIPLE in the invocation of ao2_callback(). If you don't have OBJ_MULTIPLE, then CMP_STOP is implied by a CMP_MATCH return.


Line 1177: 		AST_VECTOR_REMOVE_ORDERED(&hint->devices, i);
Why use the ORDERED version here?


-- 
To view, visit https://gerrit.asterisk.org/312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes