[Asterisk-code-review] main/pbx: Improve performance of dialplan reloads with large... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: main/pbx: Improve performance of dialplan reloads with large numbers of hints
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/312/1//COMMIT_MSG
Commit Message:

Line 7: main/pbx: Improve performance of dialplan reloads with large numbers of hints
...number...


https://gerrit.asterisk.org/#/c/312/1/main/pbx.c
File main/pbx.c:

Line 1085: static int hintdevice_hash_cb(const void *obj, const int flags)
ao2 template from wiki
https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=25919686


Line 1110: static int hintdevice_cmp_multiple(void *obj, void *arg, int flags)
This should be using the ao2 "Unsorted container cmp function" template from the wiki.
https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=25919686

The OBJ_POINTER and OBJ_PARTIAL_KEY identifiers are deprecated in v12+ in favour of OBJ_SEARCH_POINTER and OBJ_SEARCH_PARTIAL_KEY.


-- 
To view, visit https://gerrit.asterisk.org/312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes