[Asterisk-code-review] Restrict functionality when ACLs are misconfigured. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Restrict functionality when ACLs are misconfigured.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/311/1/channels/chan_iax2.c
File channels/chan_iax2.c:

Line 13749: 				return -1;
> Is this a separate bug fix?
No, add_calltoken_ignore() adds an ACL and returns an error if there was an error adding the ACL. This just propagates the error return further so that things fail when there's a bad ACL.


https://gerrit.asterisk.org/#/c/311/1/main/acl.c
File main/acl.c:

Line 989
> Is there any additional information that can be put here to clarify in what
Unfortunately, I don't believe we leave the breadcrumb trail necessary to know this. As ACL statements are encountered, a large list of the statements is built up, but the source of each element in the path is unknown.


-- 
To view, visit https://gerrit.asterisk.org/311
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ebcb6959cefad03cea4d81401be946203fcacae
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes