[Asterisk-code-review] pjsip: Add test for outbound registration with line support. (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: pjsip: Add test for outbound registration with line support.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

There are a couple of nitpicky things but mostly good.

https://gerrit.asterisk.org/#/c/286/1/tests/channels/pjsip/registration/outbound/line_parameter/sipp/register.xml
File tests/channels/pjsip/registration/outbound/line_parameter/sipp/register.xml:

Line 73:       To: test <sip:test@[remote_ip]:[remote_port]>[peer_tag_param]
The To header in the ACK should be the same as it was for the INVITE

    To: <[$contact]>[peer_tag_param]


Line 90:       To: test <sip:test@[remote_ip]:[remote_port]>[peer_tag_param]
Same To header here as well.


-- 
To view, visit https://gerrit.asterisk.org/286
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c80a969e4f29d49e83a03b3b0fed395d6ce2421
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes