[Asterisk-code-review] res fax: allow 2400 transmission rate according to v.27bis/t... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Wed Apr 29 13:23:04 CDT 2015


Kevin Harwell has uploaded a new change for review.

  https://gerrit.asterisk.org/295

Change subject: res_fax: allow 2400 transmission rate according to v.27bis/ter standards
......................................................................

res_fax: allow 2400 transmission rate according to v.27bis/ter standards

A previous set of patches (see: ASTERISK-22790 & ASTERISK-23231) made it so
a v.27 modem was not allowed to have a minimum transmission rate of 2400 bits
per second. This reverts all or some of those patches since according to the
v.27bis and v.27ter standards a rate of 2400 bits per second is supported.

ASTERISK-24955 #close
Reported by: Matt Jordan

Change-Id: I4b9dfb6bf7eff08463ab47ee1a74224f27cae733
---
M res/res_fax.c
1 file changed, 1 insertion(+), 9 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/95/295/1

diff --git a/res/res_fax.c b/res/res_fax.c
index f0679bc..65fce5c 100644
--- a/res/res_fax.c
+++ b/res/res_fax.c
@@ -936,22 +936,14 @@
 {
 	switch (rate) {
 	case 2400:
-		if (!(modems & (AST_FAX_MODEM_V34))) {
-			return 1;
-		}
-		break;
 	case 4800:
 		if (!(modems & (AST_FAX_MODEM_V27 | AST_FAX_MODEM_V34))) {
 			return 1;
 		}
 		break;
 	case 7200:
-		if (!(modems & (AST_FAX_MODEM_V17 | AST_FAX_MODEM_V29 | AST_FAX_MODEM_V34))) {
-			return 1;
-		}
-		break;
 	case 9600:
-		if (!(modems & (AST_FAX_MODEM_V17 | AST_FAX_MODEM_V27 | AST_FAX_MODEM_V29 | AST_FAX_MODEM_V34))) {
+		if (!(modems & (AST_FAX_MODEM_V17 | AST_FAX_MODEM_V29 | AST_FAX_MODEM_V34))) {
 			return 1;
 		}
 		break;

-- 
To view, visit https://gerrit.asterisk.org/295
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b9dfb6bf7eff08463ab47ee1a74224f27cae733
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list