[Asterisk-code-review] cel pgsql: Add support schema on table name and fix query co... (asterisk[master])

[Rodrigo Ramirez Norambuena]

Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: cel_pgsql: Add support schema on table name and fix query columns name.
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/120/5/cel/cel_pgsql.c
File cel/cel_pgsql.c:

Line 572: 			snprintf(sqlcmd, sizeof(sqlcmd), 
Here i thinks is necessary remove the space.


Line 609: 			int int_flen = 0;
> I don't understand - what do you want me to see there?
Sorry, i explain little more.

The initial change was a port commit of witch allow add a schema name on table configuration file, example table=public.cdr.

In interactions  of review Matt wrote https://gerrit.asterisk.org/#/c/120/3/cel/cel_pgsql.c@556 the logic where is remove the schema, after that i thought it would be better add schema parameter on configuration files instead add this feature on the name of table.

What do you thinks? Witch is best way?


-- 
To view, visit https://gerrit.asterisk.org/120
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I691fd2cbc277fcba10e615f5884f8de5d8152f2c
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes