[Asterisk-code-review] cel pgsql: Add support schema on table name and fix query co... (asterisk[master])

[Rodrigo Ramirez Norambuena]

Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: cel_pgsql: Add support schema on table name and fix query columns name.
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/120/5/cel/cel_pgsql.c
File cel/cel_pgsql.c:

Line 558: 				tmp_schemaname = ast_alloca(lenschema * 2 + 1);
        : 				strncpy(tmp_schemaname, table, lenschema);
        : 				*tmp_schemaname++ = '\0';
        : 				tmp_tablename++;
        : 			} else {
        : 				tmp_schemaname = "";
        : 				tmp_tablename = table;
        : 			}
        : 
        : 			tablename = ast_alloca(strlen(tmp_tablename) * 2 + 1);
        : 			schemaname = ast_alloca(lenschema * 2 + 1);
> Why did you decide on * 2?
Initially this change was a  port commit 2d60b755 of cdr/cdr_pgsql.c for cel/cel_pgsql.c

Is not ok *2?


Line 609: 			int int_flen = 0;
> Variables have to be declared at the start of a block or else this won't bu
Ok. i'll the change. 

Other thing, you can check i wrote on https://gerrit.asterisk.org/#/c/120/3/cel/cel_pgsql.c@556 ?


-- 
To view, visit https://gerrit.asterisk.org/120
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I691fd2cbc277fcba10e615f5884f8de5d8152f2c
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <decipher.hk at gmail.com>
Gerrit-HasComments: Yes