[Asterisk-code-review] res pjsip outbound registration: Add debugging messages. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip_outbound_registration: Add debugging messages.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/263/1/res/res_pjsip_outbound_registration.c
File res/res_pjsip_outbound_registration.c:

Line 485: 	ast_debug(1, "Attempting scheduled outbound registration attempt to %.*s\n",
        : 			(int) info.server_uri.slen, info.server_uri.ptr);
I think these sort of log messages also need to include the client URI. Without it you may not know precisely which outbound registration (if you have multiple to the same server URI).


Line 490: 		ast_log(LOG_WARNING, "Scheduled outbound registration to %.*s could not be executed\n",
        : 				(int) info.server_uri.slen, info.server_uri.ptr);
Same.


Line 508: 	ast_debug(1, "Scheduling outbound registration to %.*s in %d seconds\n", (int) info.server_uri.slen,
        : 			info.server_uri.ptr, seconds);
Same.


Line 513: ast_log(LOG_WARNING, "Failed to schedule registration to %.*s\n",
        : 				(int) info.server_uri.slen, info.server_uri.ptr);
Same.


-- 
To view, visit https://gerrit.asterisk.org/263
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I577bde7860be0a6c872b5bcb4d5047340bf45d45
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes