[Asterisk-code-review] chan pjsip: Creating Channel Causes Asterisk to Crash When D... (testsuite[master])

Ashley Sanders asteriskteam at digium.com
Tue Apr 28 00:33:56 CDT 2015


Hello Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/241

to look at the new patch set (#5).

Change subject: chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR             Sections Exist in pjsip.conf
......................................................................

chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR
            Sections Exist in pjsip.conf

This test contains two tests: [duplicate_sections] and [happy_config].

For the [duplicate_sections] test:
This test ensures Asterisk gracefully handles the situation where
duplicate sections are defined in pjsip.conf. Seven (7) test scenarios
are utilized to confirm configuring pjsip.conf with sections containing an
identical id/type combination as another section in the file, results in
Asterisk rejecting the configuration for the given object type. Each test
scenario uses its own Asterisk instance to exercise a different id/type
combination.

The test scenarios:
Scenario [1] -> ast1: Tests duplicate [id=siptrunk, type=aor] sections
Scenario [2] -> ast2: Tests duplicate [id=siptrunk, type=auth] sections
Scenario [3] -> ast3: Tests duplicate [id=siptrunk, type=contact] sections
Scenario [4] -> ast4: Tests duplicate [id=siptrunk, type=endpoint] sections
Scenario [5] -> ast5: Tests duplicate [id=siptrunk, type=identify] sections
Scenario [6] -> ast6: Tests duplicate [id=siptrunk, type=registration] sections
Scenario [7] -> ast7: Tests duplicate [id=siptrunk, type=transport] sections

For the [happy_config] test:
This test uses a pjsip.conf that represents the unique sections from the
base configuration for the [duplicate_sections] test, to ensure Asterisk
does not misidentify and reject a correct configuration.

ASTERISK-24996
Reported By: Ashley Sanders

Change-Id: I36078aae985050cff323ace3ccfd7464fe1de35f
---
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast1/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast10/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast11/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast2/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast3/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast4/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast5/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast6/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast7/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast8/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/configs/ast9/pjsip.conf
A tests/channels/pjsip/configuration/duplicate_sections/duplicate_sections.py
A tests/channels/pjsip/configuration/duplicate_sections/test-config.yaml
A tests/channels/pjsip/configuration/happy_config/configs/ast1/pjsip.conf
A tests/channels/pjsip/configuration/happy_config/happy_config.py
A tests/channels/pjsip/configuration/happy_config/test-config.yaml
A tests/channels/pjsip/configuration/test_harness.py
A tests/channels/pjsip/configuration/test_scenario.py
A tests/channels/pjsip/configuration/tests.yaml
M tests/channels/pjsip/tests.yaml
20 files changed, 2,014 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/41/241/5
-- 
To view, visit https://gerrit.asterisk.org/241
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36078aae985050cff323ace3ccfd7464fe1de35f
Gerrit-PatchSet: 5
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list