[Asterisk-code-review] res pjsip: Fix SEGV on pending-qualify contacts (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: Fix SEGV on pending-qualify contacts
......................................................................


Patch Set 1:

> I'm not sure I agree with that. We got on without it fine
 > previously. Lack of status just means that the status is unknown
 > (since it's not tracked).

Yeah, but we weren't associating contact state to endpoint state before.  Because there was no initial contact status, I would have had to add created and deleted observers for contact status.

Honestly, I think that fact that permanent contacts aren't real sorcery objects but dynamic contacts are adds to the complexity.

Anyway, -1 this if you don't feel comfortable with it and I can revisit when I get home later this week.  I'm on the road and won't be available again until Thursday.

-- 
To view, visit https://gerrit.asterisk.org/261
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc13e5cedcafb24c400368b515b02d7fb81e029
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No