[Asterisk-code-review] res pjsip: Fix SEGV on pending-qualify contacts (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: Fix SEGV on pending-qualify contacts
......................................................................


Patch Set 1:

> I think we need to step back and take a look at this code and how
 > it should behave in these various scenarios, and whether keeping
 > the "every contact has a status" which was introduced is worth it.
 > So far it seems as though it's been complicating things.

I think it's more that I just missed a few things the first time around by forgetting that permanent and dynamic contacts don't generate the same lifecycle events.  I think having the status is correct and necessary to propagate contact status to endpoints.  Otherwise we'd more hacks to handle no-status.

-- 
To view, visit https://gerrit.asterisk.org/261
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc13e5cedcafb24c400368b515b02d7fb81e029
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No