[Asterisk-code-review] chan pjsip: Creating Channel Causes Asterisk to Crash When D... (testsuite[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR Sections Exist in pjsip.conf
......................................................................


Patch Set 2:

> Sorcery/res_pjsip do not currently consider the failure of a
 > specific object type to load as a failure of the entire sorcery
 > instance itself. The scope of the failure is limited to the object
 > type itself. That is, none of those object types will be loaded.
Yes, you are correct. This test was posted prior to our conversation. I should have added a comment on Thursday indicating that this test needed some revising. 

> This test needs to be reworked within that restriction.

 > Sorcery/res_pjsip do not currently consider the failure of a
 > specific object type to load as a failure of the entire sorcery
 > instance itself. The scope of the failure is limited to the object
 > type itself. That is, none of those object types will be loaded.
 > This test needs to be reworked within that restriction.

-- 
To view, visit https://gerrit.asterisk.org/241
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36078aae985050cff323ace3ccfd7464fe1de35f
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No